Skip to content

HDDS-15311. [DiskBalancer] Fix DiskBalancer DN container Log Format#10307

Merged
ChenSammi merged 3 commits into
apache:masterfrom
Gargi-jais11:HDDS-15311
May 21, 2026
Merged

HDDS-15311. [DiskBalancer] Fix DiskBalancer DN container Log Format#10307
ChenSammi merged 3 commits into
apache:masterfrom
Gargi-jais11:HDDS-15311

Conversation

@Gargi-jais11
Copy link
Copy Markdown
Contributor

@Gargi-jais11 Gargi-jais11 commented May 19, 2026

What changes were proposed in this pull request?

DN container log file format as key worded columns is different in case of DiskBalancer compared to existing log lines. This may cause issue in any dn container formatter or parser in future.

2026-05-15 04:24:11,501 | INFO  | ID=11 | Index=0 | BCSID=1374 | State=CLOSED | Volume=/hadoop-ozone/datanode/data/hdds | DataChecksum=47c5ddd3 |
2026-05-15 05:02:20,188 | INFO  | ID=11 | SrcVolume=/hadoop-ozone/datanode/data/hdds | DestVolume=/data0/nvme1n1/hadoop-ozone/datanode/data/hdds | Size=268435456 bytes | TimeTaken=490 ms | Container is moved from SrcVolume to DestVolume |
2026-05-15 07:12:08,285 | INFO  | ID=11 | Index=0 | BCSID=1374 | State=CLOSED | Volume=/data0/nvme1n1/hadoop-ozone/datanode/data/hdds | DataChecksum=47c5ddd3 | Container reconciled with peer a49d6e1b-ee75-46c5-84eb-3ebde58b686f(datanode1.com/xx.xx.xx.xx). No change in checksum. |

DiskBalancer should maintain the same structure.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15311

How was this patch tested?

Tested manually.
Before:

2026-05-15 05:02:20,188 | INFO  | ID=11 | SrcVolume=/hadoop-ozone/datanode/data/hdds | DestVolume=/data0/nvme1n1/hadoop-ozone/datanode/data/hdds | Size=268435456 bytes | TimeTaken=490 ms | Container is moved from SrcVolume to DestVolume |

After:

2026-05-19 04:51:12,068 | INFO  | ID=13 | Index=0 | BCSID=16965 | State=CLOSED | Volume=/data/hdds1/hdds | DataChecksum=2cc81c5e |
2026-05-19 04:51:12,069 | INFO  | ID=14 | Index=0 | BCSID=16973 | State=CLOSED | Volume=/data/hdds1/hdds | DataChecksum=595237d2 |
2026-05-19 04:54:17,660 | INFO  | ID=13 | Index=0 | BCSID=16965 | State=CLOSED | SrcVolume=/data/hdds1/hdds | DestVolume=/data/hdds2/hdds | Size=967835648 bytes | TimeTaken=1777 ms | Container is moved from SrcVolume to DestVolume |
2026-05-19 04:55:17,405 | INFO  | ID=14 | Index=0 | BCSID=16973 | State=CLOSED | SrcVolume=/data/hdds1/hdds | DestVolume=/data/hdds2/hdds | Size=967835648 bytes | TimeTaken=1520 ms | Container is moved from SrcVolume to DestVolume |

@Gargi-jais11 Gargi-jais11 requested review from ChenSammi and ssulav May 19, 2026 07:30
@Gargi-jais11 Gargi-jais11 marked this pull request as ready for review May 19, 2026 07:49
@ChenSammi ChenSammi requested a review from Copilot May 19, 2026 10:33
Copilot AI reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ChenSammi ChenSammi requested a review from Copilot May 19, 2026 15:41
Copilot AI reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ChenSammi ChenSammi requested a review from Copilot May 20, 2026 01:46
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread ...ervice/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java Outdated
Comment thread ...er-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
@Gargi-jais11
Copy link
Copy Markdown
Contributor Author

Gargi-jais11 commented May 20, 2026

@ChenSammi Please re-review, I have addressed the comments.

ChenSammi
ChenSammi approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.

@ChenSammi ChenSammi merged commit dc4ce7e into apache:master May 21, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ChenSammi ChenSammi ChenSammi approved these changes

@ssulav ssulav Awaiting requested review from ssulav

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gargi-jais11 @ChenSammi